From 69ea2cf327f82365b382d41a682b55f95b97568b Mon Sep 17 00:00:00 2001
From: Kepi <kepi@igloonet.cz>
Date: Fri, 1 Sep 2017 01:30:50 +0200
Subject: [PATCH] password_fill: Stop filling username to invisible input
 fields

There is no reason to fill usernames into invisible input fields. We are
probably not leaking anything but it can break some apps (like TTRSS).
---
 misc/userscripts/password_fill | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/misc/userscripts/password_fill b/misc/userscripts/password_fill
index 327a55690..00dd55e63 100755
--- a/misc/userscripts/password_fill
+++ b/misc/userscripts/password_fill
@@ -327,6 +327,17 @@ open_entry "$file"
 
 js() {
 cat <<EOF
+    function isVisible(elem) {
+        var style = elem.ownerDocument.defaultView.getComputedStyle(elem, null);
+
+        if (style.getPropertyValue("visibility") !== "visible" ||
+            style.getPropertyValue("display") === "none" ||
+            style.getPropertyValue("opacity") === "0") {
+            return false;
+        }
+
+        return elem.offsetWidth > 0 && elem.offsetHeight > 0;
+    };
     function hasPasswordField(form) {
         var inputs = form.getElementsByTagName("input");
         for (var j = 0; j < inputs.length; j++) {
@@ -341,7 +352,7 @@ cat <<EOF
         var inputs = form.getElementsByTagName("input");
         for (var j = 0; j < inputs.length; j++) {
             var input = inputs[j];
-            if (input.type == "text" || input.type == "email") {
+            if (isVisible(input) && (input.type == "text" || input.type == "email")) {
                 input.focus();
                 input.value = "$(javascript_escape "${username}")";
                 input.blur();