rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

move savefile flush into try: block

Browse Source 
it seems flush might throw which will not be caught inside the (try-)
else branch. (hopefully) fixes config corruption when no space
available.
This commit is contained in:
Patric Schmitz 2016-06-28 00:58:56 +02:00
parent 72e5bf35e1
commit 69ce9a942c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/utils/qtutils.py
View File

@ -207,12 +207,11 @@ def savefile_open(filename, binary=False, encoding='utf-8'):
else: else:
new_f = io.TextIOWrapper(PyQIODevice(f), encoding=encoding) new_f = io.TextIOWrapper(PyQIODevice(f), encoding=encoding)
yield new_f yield new_f
new_f.flush()
except: except:
f.cancelWriting() f.cancelWriting()
cancelled = True cancelled = True
raise raise
else:
new_f.flush()
finally: finally:
commit_ok = f.commit() commit_ok = f.commit()
if not commit_ok and not cancelled: if not commit_ok and not cancelled: