rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't treat any valid int as IP

Browse Source
This commit is contained in:
Florian Bruhin 2014-11-24 21:49:48 +01:00
parent 7be32dd70c
commit 6973050ccc
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/utils/urlutils.py
View File

@ -85,12 +85,18 @@ def _is_url_naive(urlstr):
else: else:
# Valid IPv4/IPv6 address # Valid IPv4/IPv6 address
return True return True
if re.search(r'^([0-9.]+|0x[a-fA-F0-9]+)$', urlstr):
# Qt treats things like "23.42" or "1337" or "0xDEAD" as valid URLs # Qt treats things like "23.42" or "1337" or "0xDEAD" as valid URLs
# which we don't want to. Note we already filtered *real* valid IPs # which we don't want to. Note we already filtered *real* valid IPs
# above. # above.
try:
int(urlstr, 0)
except ValueError:
pass
else:
return False return False
elif not url.isValid():
if not url.isValid():
return False return False
elif '.' in url.host(): elif '.' in url.host():
return True return True