From 4dfe1c6ab66e5fc4a3b775f82a1b41dfe999d7f5 Mon Sep 17 00:00:00 2001 From: Eric Drechsel Date: Mon, 24 Oct 2016 10:17:39 -0700 Subject: [PATCH 1/3] Set the bundle identifier to a fake value to allow icu data to be found. --- misc/qutebrowser.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/qutebrowser.spec b/misc/qutebrowser.spec index d6045feaa..96345485d 100644 --- a/misc/qutebrowser.spec +++ b/misc/qutebrowser.spec @@ -71,4 +71,4 @@ app = BUNDLE(coll, name='qutebrowser.app', icon=icon, info_plist={'NSHighResolutionCapable': 'True'}, - bundle_identifier=None) + bundle_identifier='org.qt-project.Qt.QtWebEngineCore') From 01344fbed789b7f6b2578f6a08138ec57fd9b1f2 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 24 Oct 2016 22:21:34 +0200 Subject: [PATCH 2/3] Add a comment --- misc/qutebrowser.spec | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/qutebrowser.spec b/misc/qutebrowser.spec index 96345485d..81983aa0b 100644 --- a/misc/qutebrowser.spec +++ b/misc/qutebrowser.spec @@ -71,4 +71,5 @@ app = BUNDLE(coll, name='qutebrowser.app', icon=icon, info_plist={'NSHighResolutionCapable': 'True'}, + # https://github.com/pyinstaller/pyinstaller/blob/b78bfe530cdc2904f65ce098bdf2de08c9037abb/PyInstaller/hooks/hook-PyQt5.QtWebEngineWidgets.py#L24 bundle_identifier='org.qt-project.Qt.QtWebEngineCore') From 4e55c7b9f01749da5fb1235a7209abc1a37909db Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 24 Oct 2016 22:21:48 +0200 Subject: [PATCH 3/3] Update authors --- README.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/README.asciidoc b/README.asciidoc index ca0135570..8f2e9d870 100644 --- a/README.asciidoc +++ b/README.asciidoc @@ -263,6 +263,7 @@ Contributors, sorted by the number of commits in descending order: * Helen Sherwood-Taylor * HalosGhost * Gregor Pohl +* Eric Drechsel * Eivind Uggedal * Dietrich Daroch * Derek Sivers