diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 944c4ce6d..eba9174b1 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -1246,15 +1246,21 @@ class WebEngineTab(browsertab.AbstractTab): @pyqtSlot(QUrl, 'QAuthenticator*') def _on_authentication_required(self, url, authenticator): + log.network.debug("Authentication requested for {}, netrc_used {}" + .format(url.toDisplayString(), self.data.netrc_used)) + netrc_success = False if not self.data.netrc_used: self.data.netrc_used = True netrc_success = shared.netrc_authentication(url, authenticator) + if not netrc_success: + log.network.debug("Asking for credentials") abort_on = [self.shutting_down, self.load_started] answer = shared.authentication_required(url, authenticator, abort_on) if not netrc_success and answer is None: + log.network.debug("Aborting auth") try: # pylint: disable=no-member, useless-suppression sip.assign(authenticator, QAuthenticator()) diff --git a/qutebrowser/browser/webkit/network/networkmanager.py b/qutebrowser/browser/webkit/network/networkmanager.py index df65b314d..8d2523456 100644 --- a/qutebrowser/browser/webkit/network/networkmanager.py +++ b/qutebrowser/browser/webkit/network/networkmanager.py @@ -275,14 +275,19 @@ class NetworkManager(QNetworkAccessManager): @pyqtSlot('QNetworkReply*', 'QAuthenticator*') def on_authentication_required(self, reply, authenticator): """Called when a website needs authentication.""" + url = reply.url() + log.network.debug("Authentication requested for {}, netrc_used {}" + .format(url.toDisplayString(), self.netrc_used)) + netrc_success = False if not self.netrc_used: self.netrc_used = True - netrc_success = shared.netrc_authentication(reply.url(), - authenticator) + netrc_success = shared.netrc_authentication(url, authenticator) + if not netrc_success: + log.network.debug("Asking for credentials") abort_on = self._get_abort_signals(reply) - shared.authentication_required(reply.url(), authenticator, + shared.authentication_required(url, authenticator, abort_on=abort_on) @pyqtSlot('QNetworkProxy', 'QAuthenticator*')