From 67c67db23074e28d85d46f5a4c02073bc51444c5 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 11 Jun 2018 21:43:27 +0200 Subject: [PATCH] Handle multiple visible children when finding lost focusProxy When we click a QTBUG link (to open in a new tab) from Qt's codereview, we get two RWHV objects which both are visible. Experimenting with .setEnabled(False) it looks like it's (hopefully always...) the last one which is the one to use. --- qutebrowser/browser/webengine/webview.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/qutebrowser/browser/webengine/webview.py b/qutebrowser/browser/webengine/webview.py index 9abf67056..8fce9edb9 100644 --- a/qutebrowser/browser/webengine/webview.py +++ b/qutebrowser/browser/webengine/webview.py @@ -79,11 +79,7 @@ class WebEngineView(QWebEngineView): log.webview.debug("Found possibly lost focusProxy: {}" .format(children)) - if not children: - return None - - assert len(children) == 1, children - return children[0] + return children[-1] if children else None def shutdown(self): self.page().shutdown()