rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pylint_checkers: Don't check binary open in openencoding.

Browse Source
This commit is contained in:
Florian Bruhin 2014-08-20 20:33:34 +02:00
parent 84e5bb9a50
commit 66a09f6993
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
scripts/pylint_checkers/openencoding.py
View File

@ -19,6 +19,7 @@
"""Make sure open() has an encoding set.""" """Make sure open() has an encoding set."""
import astroid
from pylint.interfaces import IAstroidChecker from pylint.interfaces import IAstroidChecker
from pylint.checkers import BaseChecker from pylint.checkers import BaseChecker
from pylint.checkers import utils from pylint.checkers import utils
@ -48,9 +49,21 @@ class OpenEncodingChecker(BaseChecker):
def _check_open_encoding(self, node): def _check_open_encoding(self, node):
"""Check that an open() call always has an encoding set.""" """Check that an open() call always has an encoding set."""
try: try:
_encoding = utils.get_argument_from_call(node, position=3, mode_arg = utils.get_argument_from_call(node, position=1,
keyword='mode')
except utils.NoSuchArgumentError:
mode_arg = None
try:
_encoding = utils.get_argument_from_call(node, position=2,
keyword='encoding') keyword='encoding')
except utils.NoSuchArgumentError: except utils.NoSuchArgumentError:
if mode_arg is not None:
mode = utils.safe_infer(mode_arg)
if (mode_arg is not None and isinstance(mode, astroid.Const) and
'b' in getattr(mode, 'value', '')):
# Files opened as binary don't need an encoding.
return
else:
self.add_message('open-without-encoding', node=node) self.add_message('open-without-encoding', node=node)