From 65a62b67a5aec4de8cf5f43dc8ae3647f69ee996 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 25 Feb 2018 14:43:30 +0100 Subject: [PATCH] Go back to using tab.openurl on config changes This seems to work most reliably at the moment... --- qutebrowser/browser/webengine/webenginetab.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 130a18c30..c3f493ba1 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -895,16 +895,12 @@ class WebEngineTab(browsertab.AbstractTab): super()._on_load_finished(ok) if not ok and not self.settings.test_attribute('content.javascript.enabled'): self.dump_async(self._error_page_workaround) - - @pyqtSlot(QUrl) - def _on_url_changed(self, url): - super()._on_url_changed(url) - if self._reload_url is not None: + if ok and self._reload_url is not None: # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-66656 log.config.debug( - "Reloading {} on {} because of config change".format( - self._reload_url.toDisplayString(), url.toDisplayString())) - self.reload() + "Reloading {} because of config change".format( + self._reload_url.toDisplayString())) + QTimer.singleShot(100, lambda url=self._reload_url: self.openurl(url)) self._reload_url = None @pyqtSlot(usertypes.NavigationRequest)