rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix webkitelem tests

Browse Source
This commit is contained in:
Florian Bruhin 2017-05-12 13:57:33 +02:00
parent 17fdda6a5e
commit 65952ca290
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/unit/browser/webkit/test_webkitelem.py
View File

@ -425,25 +425,28 @@ class TestRemoveBlankTarget:
@pytest.mark.parametrize('tagname', ['a', 'area']) @pytest.mark.parametrize('tagname', ['a', 'area'])
@pytest.mark.parametrize('target', ['_self', '_parent', '_top', '']) @pytest.mark.parametrize('target', ['_self', '_parent', '_top', ''])
def test_keep_target(self, tagname, target): def test_keep_target(self, tagname, target):
elem = get_webelem(tagname=tagname, attributes={'target': target}) elem = get_webelem(tagname=tagname,
attributes={'target': target, 'href': '#'})
elem.remove_blank_target() elem.remove_blank_target()
assert elem['target'] == target assert elem['target'] == target
@pytest.mark.parametrize('tagname', ['a', 'area']) @pytest.mark.parametrize('tagname', ['a', 'area'])
def test_no_target(self, tagname): def test_no_target(self, tagname):
elem = get_webelem(tagname=tagname) elem = get_webelem(tagname=tagname, attributes={'href': '#'})
elem.remove_blank_target() elem.remove_blank_target()
assert 'target' not in elem assert 'target' not in elem
@pytest.mark.parametrize('tagname', ['a', 'area']) @pytest.mark.parametrize('tagname', ['a', 'area'])
def test_blank_target(self, tagname): def test_blank_target(self, tagname):
elem = get_webelem(tagname=tagname, attributes={'target': '_blank'}) elem = get_webelem(tagname=tagname,
attributes={'target': '_blank', 'href': '#'})
elem.remove_blank_target() elem.remove_blank_target()
assert elem['target'] == '_top' assert elem['target'] == '_top'
@pytest.mark.parametrize('tagname', ['a', 'area']) @pytest.mark.parametrize('tagname', ['a', 'area'])
def test_ancestor_blank_target(self, tagname): def test_ancestor_blank_target(self, tagname):
elem = get_webelem(tagname=tagname, attributes={'target': '_blank'}) elem = get_webelem(tagname=tagname,
attributes={'target': '_blank', 'href': '#'})
elem_child = get_webelem(tagname='img', parent=elem._elem) elem_child = get_webelem(tagname='img', parent=elem._elem)
elem_child._elem.encloseWith(elem._elem) elem_child._elem.encloseWith(elem._elem)
elem_child.remove_blank_target() elem_child.remove_blank_target()