From 6437a28184f81868d7f80e2bb34912b57eab5cd9 Mon Sep 17 00:00:00 2001 From: Jussi Timperi Date: Sat, 10 Sep 2016 17:55:00 +0300 Subject: [PATCH] QtWebKit: Add version checks to visibility API --- qutebrowser/browser/webkit/webview.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/qutebrowser/browser/webkit/webview.py b/qutebrowser/browser/webkit/webview.py index 67ca268fb..7faa0200d 100644 --- a/qutebrowser/browser/webkit/webview.py +++ b/qutebrowser/browser/webkit/webview.py @@ -72,9 +72,12 @@ class WebView(QWebView): page = webpage.BrowserPage(self.win_id, self._tab_id, tab.data, parent=self) - page.setVisibilityState( - QWebPage.VisibilityStateVisible if self.isVisible() - else QWebPage.VisibilityStateHidden) + + if qtutils.version_check('5.2'): + page.setVisibilityState( + page.VisibilityStateVisible if self.isVisible() + else page.VisibilityStateHidden) + self.setPage(page) mode_manager = objreg.get('mode-manager', scope='window', @@ -253,7 +256,10 @@ class WebView(QWebView): Return: The superclass event return value. """ - self.page().setVisibilityState(QWebPage.VisibilityStateVisible) + if qtutils.version_check('5.2'): + page = self.page() + page.setVisibilityState(page.VisibilityStateVisible) + super().showEvent(e) def hideEvent(self, e): @@ -265,5 +271,8 @@ class WebView(QWebView): Return: The superclass event return value. """ - self.page().setVisibilityState(QWebPage.VisibilityStateHidden) + if qtutils.version_check('5.2'): + page = self.page() + page.setVisibilityState(page.VisibilityStateHidden) + super().hideEvent(e)