rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use _cat_from_index in completionmodel.data.

Browse Source 
Keep all the category lookup inside _cat_from_idx for easier refactoring
if the organization ever changes.
This commit is contained in:
Ryan Roden-Corrent 2017-06-20 22:08:23 -04:00
parent 0f585eda4f
commit 63cb88a0f4
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qutebrowser/completion/models/completionmodel.py
View File

@ -75,15 +75,18 @@ class CompletionModel(QAbstractItemModel):
Return: The item data, or None on an invalid index. Return: The item data, or None on an invalid index.
""" """
if not index.isValid() or role != Qt.DisplayRole: if role != Qt.DisplayRole:
return None return None
if not index.parent().isValid(): cat = self._cat_from_idx(index)
if cat:
# category header # category header
if index.column() == 0: if index.column() == 0:
return self._categories[index.row()].name return self._categories[index.row()].name
return None return None
# item # item
cat = self._categories[index.parent().row()] cat = self._cat_from_idx(index.parent())
if not cat:
return None
idx = cat.index(index.row(), index.column()) idx = cat.index(index.row(), index.column())
return cat.data(idx) return cat.data(idx)