rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle float in _convert_js_arg

Browse Source 
This fixes 'gg' with QtWebEngine.
This commit is contained in:
Florian Bruhin 2016-08-08 08:04:55 +02:00
parent 96087bd554
commit 627f743c26
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/utils/javascript.py
View File

@ -55,7 +55,7 @@ def _convert_js_arg(arg):
return 'undefined' return 'undefined'
elif isinstance(arg, str): elif isinstance(arg, str):
return '"{}"'.format(string_escape(arg)) return '"{}"'.format(string_escape(arg))
elif isinstance(arg, int): elif isinstance(arg, (int, float)):
return str(arg) return str(arg)
else: else:
raise TypeError("Don't know how to handle {!r} of type {}!".format( raise TypeError("Don't know how to handle {!r} of type {}!".format(

1
tests/unit/utils/test_javascript.py
View File

@ -126,6 +126,7 @@ class TestStringEscape:
('foobar', '"foobar"'), ('foobar', '"foobar"'),
('foo\\bar', r'"foo\\bar"'), ('foo\\bar', r'"foo\\bar"'),
(42, '42'), (42, '42'),
(23.42, '23.42'),
(None, 'undefined'), (None, 'undefined'),
(object(), TypeError), (object(), TypeError),
]) ])