rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix return values of AbstractPrinting.check_*_support

Browse Source
This commit is contained in:
Florian Bruhin 2018-11-29 19:10:47 +01:00
parent f81c5b7eab
commit 609b8f1cee
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/browser/browsertab.py
View File

@ -205,7 +205,7 @@ class AbstractPrinting:
self._widget = None self._widget = None
self._tab = tab self._tab = tab
def check_pdf_support(self) -> bool: def check_pdf_support(self) -> None:
"""Check whether writing to PDFs is supported. """Check whether writing to PDFs is supported.
If it's not supported (by the current Qt version), a WebTabError is If it's not supported (by the current Qt version), a WebTabError is
@ -213,7 +213,7 @@ class AbstractPrinting:
""" """
raise NotImplementedError raise NotImplementedError
def check_printer_support(self) -> bool: def check_printer_support(self) -> None:
"""Check whether writing to a printer is supported. """Check whether writing to a printer is supported.
If it's not supported (by the current Qt version), a WebTabError is If it's not supported (by the current Qt version), a WebTabError is
@ -221,7 +221,7 @@ class AbstractPrinting:
""" """
raise NotImplementedError raise NotImplementedError
def check_preview_support(self) -> bool: def check_preview_support(self) -> None:
"""Check whether showing a print preview is supported. """Check whether showing a print preview is supported.
If it's not supported (by the current Qt version), a WebTabError is If it's not supported (by the current Qt version), a WebTabError is

2
qutebrowser/browser/webengine/webenginetab.py
View File

@ -132,7 +132,7 @@ class WebEnginePrinting(browsertab.AbstractPrinting):
"""QtWebEngine implementations related to printing.""" """QtWebEngine implementations related to printing."""
def check_pdf_support(self): def check_pdf_support(self):
return True pass
def check_printer_support(self): def check_printer_support(self):
if not hasattr(self._widget.page(), 'print'): if not hasattr(self._widget.page(), 'print'):