rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use a real webengine_tab for TestWebengineScripts

Browse Source 
This means the tests take a bit longer (1.2s instead of 0.6s), but I consider
that worth the trade-off for testing a real-world scenario.
This commit is contained in:
Florian Bruhin 2018-10-05 23:22:31 +02:00
parent c225e724ac
commit 5ff5ca72d8
1 changed files with 18 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tests/unit/browser/webengine/test_webenginetab.py
View File

@ -19,7 +19,6 @@
"""Test webenginetab.""" """Test webenginetab."""
from unittest import mock
import logging import logging
from PyQt5.QtCore import QObject from PyQt5.QtCore import QObject
@ -35,28 +34,14 @@ pytestmark = pytest.mark.usefixtures('greasemonkey_manager')
class TestWebengineScripts: class TestWebengineScripts:
"""Test the _WebEngineScripts utility class.""" """Test the _WebEngineScripts utility class."""
class FakeWidget(QObject):
"""Fake widget for _WebengineScripts to use."""
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.scripts = []
self.page = mock.create_autospec(QWebEnginePage)
self.scripts_mock = mock.create_autospec(
QWebEngineScriptCollection
)
self.scripts_mock.toList.return_value = self.scripts
self.page.return_value.scripts.return_value = self.scripts_mock
@pytest.fixture @pytest.fixture
def mocked_scripts(self, fake_web_tab): def webengine_scripts(self, webengine_tab):
scripts = webenginetab._WebEngineScripts(fake_web_tab) return webengine_tab._scripts
scripts._widget = self.FakeWidget()
return scripts
def test_greasemonkey_undefined_world(self, mocked_scripts, caplog): def test_greasemonkey_undefined_world(self, webengine_scripts, caplog):
"""Make sure scripts with non-existent worlds are rejected.""" """Make sure scripts with non-existent worlds are rejected."""
scripts = [ scripts = [
greasemonkey.GreasemonkeyScript( greasemonkey.GreasemonkeyScript(
@ -64,16 +49,18 @@ class TestWebengineScripts:
] ]
with caplog.at_level(logging.ERROR, 'greasemonkey'): with caplog.at_level(logging.ERROR, 'greasemonkey'):
mocked_scripts._inject_greasemonkey_scripts(scripts) webengine_scripts._inject_greasemonkey_scripts(scripts)
assert len(caplog.records) == 1 assert len(caplog.records) == 1
msg = caplog.records[0].message msg = caplog.records[0].message
assert "has invalid value for '@qute-js-world': Mars" in msg assert "has invalid value for '@qute-js-world': Mars" in msg
mocked_scripts._widget.scripts_mock.insert.assert_not_called() collection = webengine_scripts._widget.page().scripts().toList()
assert not any(script.name().startswith('GM-')
for script in collection)
@pytest.mark.parametrize("worldid", [-1, 257]) @pytest.mark.parametrize("worldid", [-1, 257])
def test_greasemonkey_out_of_range_world(self, worldid, def test_greasemonkey_out_of_range_world(self, worldid, webengine_scripts,
mocked_scripts, caplog): caplog):
"""Make sure scripts with out-of-range worlds are rejected.""" """Make sure scripts with out-of-range worlds are rejected."""
scripts = [ scripts = [
greasemonkey.GreasemonkeyScript( greasemonkey.GreasemonkeyScript(
@ -81,17 +68,19 @@ class TestWebengineScripts:
] ]
with caplog.at_level(logging.ERROR, 'greasemonkey'): with caplog.at_level(logging.ERROR, 'greasemonkey'):
mocked_scripts._inject_greasemonkey_scripts(scripts) webengine_scripts._inject_greasemonkey_scripts(scripts)
assert len(caplog.records) == 1 assert len(caplog.records) == 1
msg = caplog.records[0].message msg = caplog.records[0].message
assert "has invalid value for '@qute-js-world': " in msg assert "has invalid value for '@qute-js-world': " in msg
assert "should be between 0 and" in msg assert "should be between 0 and" in msg
mocked_scripts._widget.scripts_mock.insert.assert_not_called() collection = webengine_scripts._widget.page().scripts().toList()
assert not any(script.name().startswith('GM-')
for script in collection)
@pytest.mark.parametrize("worldid", [0, 10]) @pytest.mark.parametrize("worldid", [0, 10])
def test_greasemonkey_good_worlds_are_passed(self, worldid, def test_greasemonkey_good_worlds_are_passed(self, worldid,
mocked_scripts, caplog): webengine_scripts, caplog):
"""Make sure scripts with valid worlds have it set.""" """Make sure scripts with valid worlds have it set."""
scripts = [ scripts = [
greasemonkey.GreasemonkeyScript( greasemonkey.GreasemonkeyScript(
@ -100,8 +89,7 @@ class TestWebengineScripts:
] ]
with caplog.at_level(logging.ERROR, 'greasemonkey'): with caplog.at_level(logging.ERROR, 'greasemonkey'):
mocked_scripts._inject_greasemonkey_scripts(scripts) webengine_scripts._inject_greasemonkey_scripts(scripts)
calls = mocked_scripts._widget.scripts_mock.insert.call_args_list collection = webengine_scripts._widget.page().scripts()
assert len(calls) == 1 assert collection.toList()[-1].worldId() == worldid
assert calls[0][0][0].worldId() == worldid