rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make callback mandatory for tab.selection()

Browse Source
This commit is contained in:
Florian Bruhin 2018-02-06 23:32:50 +01:00
parent ce8d15d2b0
commit 5fd3943ebc
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/browsertab.py
View File

@ -392,7 +392,7 @@ class AbstractCaret(QObject):
def drop_selection(self): def drop_selection(self):
raise NotImplementedError raise NotImplementedError
def selection(self, callback=None): def selection(self, callback):
raise NotImplementedError raise NotImplementedError
def follow_selected(self, *, tab=False): def follow_selected(self, *, tab=False):

2
qutebrowser/browser/webengine/webenginetab.py
View File

@ -289,7 +289,7 @@ class WebEngineCaret(browsertab.AbstractCaret):
def drop_selection(self): def drop_selection(self):
self._js_call('dropSelection') self._js_call('dropSelection')
def selection(self, callback=None): def selection(self, callback):
# Not using selectedText() as WORKAROUND for # Not using selectedText() as WORKAROUND for
# https://bugreports.qt.io/browse/QTBUG-53134 # https://bugreports.qt.io/browse/QTBUG-53134
# Even on Qt 5.10 selectedText() seems to work poorly, see # Even on Qt 5.10 selectedText() seems to work poorly, see