From 5fb6cb713b7047cec245ea7a3a19dddfbc1cf5aa Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 10 Jul 2017 07:59:56 +0200 Subject: [PATCH] Hide back/forward widget when there's no text --- qutebrowser/mainwindow/statusbar/backforward.py | 1 + tests/unit/mainwindow/statusbar/test_backforward.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/qutebrowser/mainwindow/statusbar/backforward.py b/qutebrowser/mainwindow/statusbar/backforward.py index a58373122..9ed18ffb0 100644 --- a/qutebrowser/mainwindow/statusbar/backforward.py +++ b/qutebrowser/mainwindow/statusbar/backforward.py @@ -39,3 +39,4 @@ class Backforward(textbase.TextBase): if text: text = '[' + text + ']' self.setText(text) + self.setVisible(bool(text)) diff --git a/tests/unit/mainwindow/statusbar/test_backforward.py b/tests/unit/mainwindow/statusbar/test_backforward.py index 24c905c2c..bf37cd55f 100644 --- a/tests/unit/mainwindow/statusbar/test_backforward.py +++ b/tests/unit/mainwindow/statusbar/test_backforward.py @@ -47,6 +47,7 @@ def test_backforward_widget(backforward_widget, stubs, tabbed_browser.tabs = [tab] backforward_widget.on_tab_cur_url_changed(tabbed_browser) assert backforward_widget.text() == expected_text + assert backforward_widget.isVisible() == bool(expected_text) # Check that the widget gets reset if empty. if can_go_back and can_go_forward: @@ -54,3 +55,4 @@ def test_backforward_widget(backforward_widget, stubs, tabbed_browser.tabs = [tab] backforward_widget.on_tab_cur_url_changed(tabbed_browser) assert backforward_widget.text() == '' + assert not backforward_widget.isVisible()