rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix renderer process test for older Qt versions

Browse Source
This commit is contained in:
Florian Bruhin 2017-07-25 17:35:42 +02:00
parent 792a01ba6d
commit 5ecda25fdb
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/mainwindow/tabbedbrowser.py
View File

@ -710,7 +710,7 @@ class TabbedBrowser(tabwidget.TabWidget):
def show_error_page(html):
tab.set_html(html)
log.webview.debug("Showed error page for renderer termination")
log.webview.error(msg)
if qtutils.version_check('5.9'):
url_string = tab.url(requested=True).toDisplayString()
@ -718,7 +718,6 @@ class TabbedBrowser(tabwidget.TabWidget):
'error.html', title="Error loading {}".format(url_string),
url=url_string, error=msg, icon='')
QTimer.singleShot(100, lambda: show_error_page(error_page))
log.webview.error(msg)
else:
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-58698
message.error(msg)

1
tests/end2end/features/misc.feature
View File

@ -700,7 +700,6 @@ Feature: Various utility commands.
And I open data/numbers/2.txt in a new tab
And I run :open chrome://kill
And I wait for "Renderer process was killed" in the log
And I wait for "Showed error page for renderer termination" in the log
And I open data/numbers/3.txt
Then no crash should happen