From 5e06d420f90bd578752082667d166583f3d9368f Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 16 Jul 2014 14:11:28 +0200 Subject: [PATCH] Fix disconnecting tab signals --- qutebrowser/widgets/webview.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qutebrowser/widgets/webview.py b/qutebrowser/widgets/webview.py index deb09437c..7c4d7027c 100644 --- a/qutebrowser/widgets/webview.py +++ b/qutebrowser/widgets/webview.py @@ -352,12 +352,15 @@ class WebView(QWebView): callback: Function to call after shutting down. """ self._shutdown_callback = callback + # Avoid loading finished signal when stopping try: - # Avoid loading finished signal when stopping self.loadFinished.disconnect() + except TypeError: + pass + try: self.page().mainFrame().loadFinished.disconnect() except TypeError: - log.destroy.exception("This should never happen.") + pass self.stop() self.close() self.settings().setAttribute(QWebSettings.JavascriptEnabled, False)