From 5d13d0073c6d93866b4ae86534f533946d77502a Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 13 May 2015 10:41:23 +0200 Subject: [PATCH] Add some tests for key config migrations. --- tests/config/test_config.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/tests/config/test_config.py b/tests/config/test_config.py index edca7ae0d..9ba458ec3 100644 --- a/tests/config/test_config.py +++ b/tests/config/test_config.py @@ -190,6 +190,37 @@ class TestKeyConfigParser: """Make sure the default config contains no deprecated commands.""" assert rgx.match(command) is None + @pytest.mark.parametrize( + 'old, new_expected', + [ + ('open -t about:blank', 'open -t'), + ('open -w about:blank', 'open -w'), + ('open -b about:blank', 'open -b'), + ('open about:blank', None), + ('open -t example.com', None), + ('download-page', 'download'), + ('cancel-download', 'download-cancel'), + ('search ""', 'search'), + ("search ''", 'search'), + ('search "foo"', None), + ('set-cmd-text "foo bar"', 'set-cmd-text foo bar'), + ("set-cmd-text 'foo bar'", 'set-cmd-text foo bar'), + ('set-cmd-text foo bar', None), + ('set-cmd-text "foo bar "', 'set-cmd-text -s foo bar'), + ("set-cmd-text 'foo bar '", 'set-cmd-text -s foo bar'), + ] + ) + def test_migrations(self, old, new_expected): + """Make sure deprecated commands get migrated correctly.""" + if new_expected is None: + new_expected = old + new = old + for rgx, repl in configdata.CHANGED_KEY_COMMANDS: + if rgx.match(new): + new = rgx.sub(repl, new) + break + assert new == new_expected + class TestDefaultConfig: