rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Change config option to in tabs.pinned group

Browse Source 
Changes to be committed:
      modified:   qutebrowser/browser/browsertab.py
      modified:   qutebrowser/config/configdata.yml
      modified:   tests/end2end/features/tabs.feature
        Changed pinned.tabs.frozen to be tabs.pinned.frozen in all of
        these files.
This commit is contained in:
adam 2019-01-06 20:53:26 -05:00
parent 9662d3aa25
commit 5cd988ae52
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/browsertab.py
View File

@ -945,7 +945,7 @@ class AbstractTab(QWidget):
def navigation_blocked(self) -> bool: def navigation_blocked(self) -> bool:
"""Test if navigation is allowed on the current tab.""" """Test if navigation is allowed on the current tab."""
return self.data.pinned and config.val.pinned.tab.frozen return self.data.pinned and config.val.tabs.pinned.frozen
@pyqtSlot(QUrl) @pyqtSlot(QUrl)
def _on_before_load_started(self, url: QUrl) -> None: def _on_before_load_started(self, url: QUrl) -> None:

10
qutebrowser/config/configdata.yml
View File

@ -1768,6 +1768,11 @@ tabs.pinned.shrink:
type: Bool type: Bool
desc: Shrink pinned tabs down to their contents. desc: Shrink pinned tabs down to their contents.
tabs.pinned.frozen:
type: Bool
default: True
desc: If true, then pinned tabs cannot have their URL changed.
tabs.wrap: tabs.wrap:
default: true default: true
type: Bool type: Bool
@ -2917,8 +2922,3 @@ bindings.commands:
* register: Entered when qutebrowser is waiting for a register name/key for * register: Entered when qutebrowser is waiting for a register name/key for
commands like `:set-mark`. commands like `:set-mark`.
pinned.tab.frozen:
type: Bool
default: True
desc: If true, then pinned tabs cannot have their URL changed.

8
tests/end2end/features/tabs.feature
View File

@ -1289,8 +1289,8 @@ Feature: Tab management
And the following tabs should be open: And the following tabs should be open:
- data/numbers/1.txt (active) (pinned) - data/numbers/1.txt (active) (pinned)
Scenario: :tab-pin open url with pinned.tab.frozen = false Scenario: :tab-pin open url with tabs.pinned.frozen = false
When I set pinned.tab.frozen to false When I set tabs.pinned.frozen to false
And I open data/numbers/1.txt And I open data/numbers/1.txt
And I run :tab-pin And I run :tab-pin
And I open data/numbers/2.txt And I open data/numbers/2.txt
@ -1305,9 +1305,9 @@ Feature: Tab management
And the following tabs should be open: And the following tabs should be open:
- data/numbers/1.txt (active) (pinned) - data/numbers/1.txt (active) (pinned)
Scenario: :home on a pinned tab with pinned.tab.frozen = false Scenario: :home on a pinned tab with tabs.pinned.frozen = false
When I set url.start_pages to ["http://localhost:(port)/data/numbers/2.txt"] When I set url.start_pages to ["http://localhost:(port)/data/numbers/2.txt"]
And I set pinned.tab.frozen to false And I set tabs.pinned.frozen to false
And I open data/numbers/1.txt And I open data/numbers/1.txt
And I run :tab-pin And I run :tab-pin
And I run :home And I run :home