rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve error messages in test_hints

Browse Source 
See #1542
This commit is contained in:
Florian Bruhin 2016-06-04 23:09:08 +02:00
parent 831c3c0272
commit 5c329c409c
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/end2end/test_hints_html.py
View File

@ -48,9 +48,24 @@ def test_hints(test_name, zoom_text_only, zoom_level, quteproc):
soup = bs4.BeautifulSoup(html, 'html.parser') soup = bs4.BeautifulSoup(html, 'html.parser')
comment = soup.find(text=lambda text: isinstance(text, bs4.Comment)) comment = soup.find(text=lambda text: isinstance(text, bs4.Comment))
parsed = yaml.load(comment)
assert set(parsed.keys()) == {'target'} if comment is None:
pytest.fail("No comment found in {}, please read "
"tests/end2end/data/hints/html/README.md".format(
test_name))
parsed = yaml.load(comment)
if not isinstance(parsed, dict):
pytest.fail("Invalid comment found in {}, please read "
"tests/end2end/data/hints/html/README.md - "
"expected yaml dict but got {}".format(
test_name, type(parsed).__name__))
if set(parsed.keys()) != {'target'}:
pytest.fail("Invalid comment found in {}, please read "
"tests/end2end/data/hints/html/README.md - "
"expected key 'target' but found {}".format(
test_name, ', '.join(set(parsed.keys()))))
# setup # setup
quteproc.send_cmd(':set ui zoom-text-only {}'.format(zoom_text_only)) quteproc.send_cmd(':set ui zoom-text-only {}'.format(zoom_text_only))