From 5a25f0b98b60d86eb46d54c47046228be0c20c1c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 5 Aug 2015 06:55:39 +0200 Subject: [PATCH] Don't crash on :completion-item-del with no item. If :completion-item-del was invoked with no item selected (e.g. directly after pressing 'o'), there was a crash because the currentIndex was invalid. /cc @antoyo (but I believe one of my changes on top of yours caused this) --- qutebrowser/completion/completer.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/completion/completer.py b/qutebrowser/completion/completer.py index bc1a9daa0..2df964658 100644 --- a/qutebrowser/completion/completer.py +++ b/qutebrowser/completion/completer.py @@ -488,6 +488,8 @@ class Completer(QObject): """Delete the current completion item.""" completion = objreg.get('completion', scope='window', window=self._win_id) + if not completion.currentIndex().isValid(): + raise cmdexc.CommandError("No item selected!") try: self.model().srcmodel.delete_cur_item(completion) except NotImplementedError: