rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'settings' of https://github.com/lahwaacz/qutebrowser into lahwaacz-settings

Browse Source
This commit is contained in:
Florian Bruhin 2016-08-29 06:52:17 +02:00
commit 5917f34eab
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/html/settings.html
View File

@ -28,7 +28,7 @@ th pre { color: grey; text-align: left; }
<tr> <tr>
<td>{{ d }} (Current: {{ confget(section, d)|truncate(100) }})</td> <td>{{ d }} (Current: {{ confget(section, d)|truncate(100) }})</td>
<td> <td>
<input type="input" <input type="text"
onblur="cset('{{ section }}', '{{ d }}', this)" onblur="cset('{{ section }}', '{{ d }}', this)"
value="{{ confget(section, d) }}"> value="{{ confget(section, d) }}">
</input> </input>

27
tests/end2end/features/set.feature
View File

@ -63,6 +63,33 @@ Feature: Setting settings.
Then the following tabs should be open: Then the following tabs should be open:
- qute:settings (active) - qute:settings (active)
@qtwebengine_todo: qute:settings is not implemented yet
Scenario: Focusing input fields in qute://settings and entering valid value
When I open qute://settings
# scroll to the right - the table does not fit in the default screen
And I run :scroll-perc -x 100
And I hint with args "inputs" and follow a
And I press the key "<Ctrl+Backspace>"
And I press the key "true"
And I press the key "<Escape>"
# an explicit Tab to unfocus the input field seems to stabilize the tests
And I press the key "<Tab>"
And I run :set general ignore-case?
Then "general ignore-case = true" should be logged
@qtwebengine_todo: qute:settings is not implemented yet
Scenario: Focusing input fields in qute://settings and entering invalid value
When I open qute://settings
# scroll to the right - the table does not fit in the default screen
And I run :scroll-perc -x 100
And I hint with args "inputs" and follow a
And I press the key "<Ctrl+Backspace>"
And I press the key "foo"
And I press the key "<Escape>"
# an explicit Tab to unfocus the input field seems to stabilize the tests
And I press the key "<Tab>"
Then "Invalid value 'foo' *" should be logged
Scenario: Empty option with ? (issue 1109) Scenario: Empty option with ? (issue 1109)
When I run :set general ? When I run :set general ?
Then the error "set: The following arguments are required: value" should be shown Then the error "set: The following arguments are required: value" should be shown