From 4e93e044680a97b8a090a3b5611da664a47877f8 Mon Sep 17 00:00:00 2001 From: nanjekyejoannah Date: Wed, 3 Aug 2016 18:55:33 +0300 Subject: [PATCH 1/4] end2end testcase for issue #844 --- tests/end2end/data/navigate/multilinelinks.html | 14 ++++++++++++++ tests/end2end/features/navigate.feature | 5 +++++ 2 files changed, 19 insertions(+) create mode 100644 tests/end2end/data/navigate/multilinelinks.html diff --git a/tests/end2end/data/navigate/multilinelinks.html b/tests/end2end/data/navigate/multilinelinks.html new file mode 100644 index 000000000..7bb34783c --- /dev/null +++ b/tests/end2end/data/navigate/multilinelinks.html @@ -0,0 +1,14 @@ + + + + + Navigate multiline links + + +

Test page

+ previous + mid + next + + + diff --git a/tests/end2end/features/navigate.feature b/tests/end2end/features/navigate.feature index 6f7976f50..39d0f6956 100644 --- a/tests/end2end/features/navigate.feature +++ b/tests/end2end/features/navigate.feature @@ -65,3 +65,8 @@ Feature: Using :navigate And I open data/numbers/1.txt And I run :navigate increment Then the error "No number found in URL!" should be shown + + Scenario: navigate matching for multiline links + when I open /data/navigate/multilinelinks.html + And I run ]] + Then /data/numbers/5.txt should be loaded From 04b007986faf18afef33113d566a9598a01ac1df Mon Sep 17 00:00:00 2001 From: nanjekyejoannah Date: Thu, 4 Aug 2016 13:47:14 +0300 Subject: [PATCH 2/4] end2end testcase for #844 --- tests/end2end/data/navigate/multilinelinks.html | 9 +++------ tests/end2end/features/navigate.feature | 10 +++++----- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/tests/end2end/data/navigate/multilinelinks.html b/tests/end2end/data/navigate/multilinelinks.html index 7bb34783c..607d34038 100644 --- a/tests/end2end/data/navigate/multilinelinks.html +++ b/tests/end2end/data/navigate/multilinelinks.html @@ -2,13 +2,10 @@ - Navigate multiline links + Navigate Multipline link -

Test page

- previous - mid - next +

page

+ next
page - diff --git a/tests/end2end/features/navigate.feature b/tests/end2end/features/navigate.feature index 39d0f6956..c43ff1c18 100644 --- a/tests/end2end/features/navigate.feature +++ b/tests/end2end/features/navigate.feature @@ -65,8 +65,8 @@ Feature: Using :navigate And I open data/numbers/1.txt And I run :navigate increment Then the error "No number found in URL!" should be shown - - Scenario: navigate matching for multiline links - when I open /data/navigate/multilinelinks.html - And I run ]] - Then /data/numbers/5.txt should be loaded + + Scenario: Navigating multiline links + When I open data/navigate/multilinelinks.html + And I run :navigate next + Then data/numbers/5.txt should be loaded From 6431cd2395982efb4f7981d55a7fc706b8f549fc Mon Sep 17 00:00:00 2001 From: nanjekyejoannah Date: Thu, 4 Aug 2016 15:43:58 +0300 Subject: [PATCH 3/4] added closing body tag --- tests/end2end/data/navigate/multilinelinks.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/end2end/data/navigate/multilinelinks.html b/tests/end2end/data/navigate/multilinelinks.html index 607d34038..7537bf6d2 100644 --- a/tests/end2end/data/navigate/multilinelinks.html +++ b/tests/end2end/data/navigate/multilinelinks.html @@ -5,7 +5,7 @@ Navigate Multipline link -

page

next
page + From 59d8264c56cc642a82f7361f0f34ff7161838f42 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 4 Aug 2016 18:22:03 +0200 Subject: [PATCH 4/4] Regenerate authors --- README.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.asciidoc b/README.asciidoc index 2779d8a73..68a62714c 100644 --- a/README.asciidoc +++ b/README.asciidoc @@ -173,12 +173,12 @@ Contributors, sorted by the number of commits in descending order: * John ShaggyTwoDope Jenkins * Peter Vilim * Clayton Craft +* nanjekyejoannah * Oliver Caldwell * Jonas Schürmann * error800 * Liam BEGUIN * skinnay -* nanjekyejoannah * Zach-Button * Tomasz Kramkowski * Ismail S