rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set tab as parent for print dialogs

Browse Source 
Fixes #2366
This commit is contained in:
Florian Bruhin 2017-03-02 18:41:28 +01:00
parent ea653e6fe4
commit 56ab02f54d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -31,6 +31,7 @@ Fixed
- Hinting a input now doesn't select existing text anymore with QtWebKit - Hinting a input now doesn't select existing text anymore with QtWebKit
- The cursor now moves to the end when input elements are selected with QtWebEngine - The cursor now moves to the end when input elements are selected with QtWebEngine
- Download suffixes like (1) are now correctly stripped with QtWebEngine - Download suffixes like (1) are now correctly stripped with QtWebEngine
- Crash when trying to print a tab which was closed in the meantime
v0.10.0 v0.10.0
------- -------

4
qutebrowser/browser/commands.py
View File

@ -350,7 +350,7 @@ class CommandDispatcher:
message.error("Printing failed!") message.error("Printing failed!")
tab.printing.check_preview_support() tab.printing.check_preview_support()
diag = QPrintPreviewDialog() diag = QPrintPreviewDialog(tab)
diag.setAttribute(Qt.WA_DeleteOnClose) diag.setAttribute(Qt.WA_DeleteOnClose)
diag.setWindowFlags(diag.windowFlags() | Qt.WindowMaximizeButtonHint | diag.setWindowFlags(diag.windowFlags() | Qt.WindowMaximizeButtonHint |
Qt.WindowMinimizeButtonHint) Qt.WindowMinimizeButtonHint)
@ -376,7 +376,7 @@ class CommandDispatcher:
message.error("Printing failed!") message.error("Printing failed!")
diag.deleteLater() diag.deleteLater()
diag = QPrintDialog() diag = QPrintDialog(tab)
diag.open(lambda: tab.printing.to_printer(diag.printer(), diag.open(lambda: tab.printing.to_printer(diag.printer(),
print_callback)) print_callback))