From 5601c8e7c11f27f14fdd582a3d5aa8bc4af8ec6c Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 24 Oct 2015 11:54:25 +0200 Subject: [PATCH] mhtml: Skip test if cssutils is unavailable Instead of failing the test (assert cssutils is not None) --- tests/unit/browser/test_mhtml.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/unit/browser/test_mhtml.py b/tests/unit/browser/test_mhtml.py index d19d6e1c6..7b5fed7be 100644 --- a/tests/unit/browser/test_mhtml.py +++ b/tests/unit/browser/test_mhtml.py @@ -228,9 +228,10 @@ def test_empty_content_type(checker): @pytest.mark.parametrize('has_cssutils', [ - True, + pytest.mark.skipif(mhtml.cssutils is None, + reason="requires cssutils")(True), False, -]) +], ids=['with_cssutils', 'no_cssutils']) @pytest.mark.parametrize('inline, style, expected_urls', [ (False, "@import 'default.css'", ['default.css']), (False, '@import "default.css"', ['default.css']), @@ -244,9 +245,7 @@ def test_empty_content_type(checker): ]) def test_css_url_scanner(monkeypatch, has_cssutils, inline, style, expected_urls): - if has_cssutils: - assert mhtml.cssutils is not None - else: + if not has_cssutils: monkeypatch.setattr('qutebrowser.browser.mhtml.cssutils', None) expected_urls.sort() urls = mhtml._get_css_imports(style, inline=inline)