Switch to using Item.get_report() for vulture

scripts/dev/run_vulture.py

@@ -141,10 +141,7 @@ def report(items):
     output = []
     for item in sorted(items,
                        key=lambda e: (e.filename.lower(), e.first_lineno)):
-        relpath = os.path.relpath(item.filename)
+        output.append(item.get_report())
-        path = relpath if not relpath.startswith('..') else item.filename
-        output.append("{}:{}: Unused {} '{}'".format(path, item.first_lineno,
-                                                     item.typ, item.name))
     return output
 
 

tests/unit/scripts/test_run_vulture.py

@@ -81,50 +81,8 @@ def test_unused_func(vultdir):
         def foo():
             pass
     """)
-    assert vultdir.run() == ["foo.py:2: Unused function 'foo'"]
+    msg = "foo.py:2: unused function 'foo' (60% confidence)"
-
+    assert vultdir.run() == [msg]
-
-def test_unused_var(vultdir):
-    vultdir.makepyfile(foo="""
-        foo = 42
-    """)
-    assert vultdir.run() == ["foo.py:2: Unused variable 'foo'"]
-
-
-def test_unused_attr(vultdir):
-    vultdir.makepyfile(foo="""
-        class Foo():
-            def __init__(self):
-                self.foo = 42
-
-        Foo()
-    """)
-    assert vultdir.run() == ["foo.py:4: Unused attribute 'foo'"]
-
-
-def test_unused_prop(vultdir):
-    vultdir.makepyfile(foo="""
-        class Foo():
-
-            @property
-            def foo(self):
-                return 42
-
-        Foo()
-    """)
-    assert vultdir.run() == ["foo.py:4: Unused property 'foo'"]
-
-
-def test_unused_method(vultdir):
-    vultdir.makepyfile(foo="""
-        class Foo():
-
-            def foo(self):
-                pass
-
-        Foo()
-    """)
-    assert vultdir.run() == ["foo.py:4: Unused function 'foo'"]
 
 
 def test_unused_method_camelcase(vultdir):