Switch to using Item.get_report() for vulture

This commit is contained in:
Florian Bruhin 2017-09-20 07:39:03 +02:00
parent 1d2d31d0f9
commit 54ceb52eaf
2 changed files with 3 additions and 48 deletions

View File

@ -141,10 +141,7 @@ def report(items):
output = []
for item in sorted(items,
key=lambda e: (e.filename.lower(), e.first_lineno)):
relpath = os.path.relpath(item.filename)
path = relpath if not relpath.startswith('..') else item.filename
output.append("{}:{}: Unused {} '{}'".format(path, item.first_lineno,
item.typ, item.name))
output.append(item.get_report())
return output

View File

@ -81,50 +81,8 @@ def test_unused_func(vultdir):
def foo():
pass
""")
assert vultdir.run() == ["foo.py:2: Unused function 'foo'"]
def test_unused_var(vultdir):
vultdir.makepyfile(foo="""
foo = 42
""")
assert vultdir.run() == ["foo.py:2: Unused variable 'foo'"]
def test_unused_attr(vultdir):
vultdir.makepyfile(foo="""
class Foo():
def __init__(self):
self.foo = 42
Foo()
""")
assert vultdir.run() == ["foo.py:4: Unused attribute 'foo'"]
def test_unused_prop(vultdir):
vultdir.makepyfile(foo="""
class Foo():
@property
def foo(self):
return 42
Foo()
""")
assert vultdir.run() == ["foo.py:4: Unused property 'foo'"]
def test_unused_method(vultdir):
vultdir.makepyfile(foo="""
class Foo():
def foo(self):
pass
Foo()
""")
assert vultdir.run() == ["foo.py:4: Unused function 'foo'"]
msg = "foo.py:2: unused function 'foo' (60% confidence)"
assert vultdir.run() == [msg]
def test_unused_method_camelcase(vultdir):