From 52ea924cbee93fcb082bfbf85dbecbe0b8e93b04 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 30 Sep 2014 07:11:54 +0200 Subject: [PATCH] prompter: Override locked mode for questions. This fixes a crash ([1], "ValueError: Mode KeyMode.yesno not on mode stack!") when a website asks a second javascript question (prompt/alert/confirm) while another one is still running. [1] http://paste.the-compiler.org/view/8c39f5ea --- qutebrowser/widgets/statusbar/prompter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/widgets/statusbar/prompter.py b/qutebrowser/widgets/statusbar/prompter.py index 872a957d3..427a016f4 100644 --- a/qutebrowser/widgets/statusbar/prompter.py +++ b/qutebrowser/widgets/statusbar/prompter.py @@ -287,7 +287,7 @@ class Prompter: question.aborted.connect(lambda: modeman.maybe_leave(mode, 'aborted')) mode_manager = objreg.get('mode-manager') try: - modeman.enter(mode, 'question asked') + modeman.enter(mode, 'question asked', override=True) except modeman.ModeLockedError: if mode_manager.mode() != usertypes.KeyMode.prompt: question.abort()