diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 567085dbd..54a4d0387 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -526,17 +526,16 @@ class HintManager(QObject): # We have to import this here to avoid a circular import. from qutebrowser.widgets import mainwindow win_id = mainwindow.create_window(True) - tab_id = 0 - else: - win_id = self._win_id - tab_id = self._tab_id - if tab: tabbed_browser = objreg.get('tabbed-browser', scope='window', window=win_id) + tabbed_browser.tabopen(url, background=False) + elif tab: + tabbed_browser = objreg.get('tabbed-browser', scope='window', + window=self._win_id) tabbed_browser.tabopen(url, background=background) else: - webview = objreg.get('webview', scope='tab', window=win_id, - tab=tab_id) + webview = objreg.get('webview', scope='tab', window=self._win_id, + tab=self._tab_id) webview.openurl(url) @cmdutils.register(instance='hintmanager', scope='tab', name='hint') diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index e0dcabd61..fa38307ea 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -315,7 +315,7 @@ class BrowserPage(QWebPage): win_id = mainwindow.create_window(True) tabbed_browser = objreg.get('tabbed-browser', scope='window', window=win_id) - tabbed_browser.openurl(url, False) + tabbed_browser.tabopen(url, False) return False else: return True