Merge branch 'airodactyl-fix/fail-tab-detach'

CHANGELOG.asciidoc

@@ -92,6 +92,7 @@ Fixed
 - `:undo` now doesn't undo tabs "closed" by `:tab-detach` anymore.
 - Fixed an issue with hint chars not being cleared correctly when leaving hint
   mode.
+- `:tab-detach` now fails correctly when there's only one tab open.
 
 v0.8.3 (unreleased)
 -------------------

README.asciidoc

@@ -178,6 +178,7 @@ Contributors, sorted by the number of commits in descending order:
 * Niklas Haas
 * Jonas Schürmann
 * error800
+* Michael Hoang
 * Liam BEGUIN
 * skinnay
 * Zach-Button
@@ -192,7 +193,6 @@ Contributors, sorted by the number of commits in descending order:
 * Nick Ginther
 * Michał Góral
 * Michael Ilsaas
-* Michael Hoang
 * Martin Zimmermann
 * Fritz Reichwald
 * Brian Jackson

qutebrowser/browser/commands.py

@@ -424,6 +424,8 @@ class CommandDispatcher:
     @cmdutils.register(instance='command-dispatcher', scope='window')
     def tab_detach(self):
         """Detach the current tab to its own window."""
+        if self._count() < 2:
+            raise cmdexc.CommandError("Cannot detach one tab.")
         url = self._current_url()
         self._open(url, window=True)
         cur_widget = self._current_widget()

tests/end2end/features/tabs.feature

@@ -620,6 +620,11 @@ Feature: Tab management
               - history:
                 - url: http://localhost:*/data/numbers/2.txt
 
+    Scenario: Detach tab from window with only one tab
+        When I open data/hello.txt
+        And I run :tab-detach
+        Then the error "Cannot detach one tab." should be shown
+
     # :undo
 
     Scenario: Undo without any closed tabs