Rename add_history_item

This commit is contained in:
Florian Bruhin 2018-11-30 08:45:45 +01:00
parent a7f7607b4d
commit 5199681b41
4 changed files with 6 additions and 5 deletions

View File

@ -854,7 +854,8 @@ class AbstractTab(QWidget):
url_changed = pyqtSignal(QUrl)
shutting_down = pyqtSignal()
contents_size_changed = pyqtSignal(QSizeF)
add_history_item = pyqtSignal(QUrl, QUrl, str) # url, requested url, title
# url, requested url, title
history_item_triggered = pyqtSignal(QUrl, QUrl, str)
fullscreen_requested = pyqtSignal(bool)
renderer_process_terminated = pyqtSignal(TerminationStatus, int)
before_load_started = pyqtSignal(QUrl)
@ -1027,7 +1028,7 @@ class AbstractTab(QWidget):
@pyqtSlot()
def _on_history_trigger(self) -> None:
"""Emit add_history_item when triggered by backend-specific signal."""
"""Emit history_item_triggered based on backend-specific signal."""
raise NotImplementedError
@pyqtSlot(int)

View File

@ -1240,7 +1240,7 @@ class WebEngineTab(browsertab.AbstractTab):
log.misc.debug("Ignoring invalid URL being added to history")
return
self.add_history_item.emit(url, requested_url, title)
self.history_item_triggered.emit(url, requested_url, title)
@pyqtSlot(QUrl, 'QAuthenticator*', 'QString')
def _on_proxy_authentication_required(self, url, authenticator,

View File

@ -769,7 +769,7 @@ class WebKitTab(browsertab.AbstractTab):
def _on_history_trigger(self):
url = self.url()
requested_url = self.url(requested=True)
self.add_history_item.emit(url, requested_url, self.title())
self.history_item_triggered.emit(url, requested_url, self.title())
def set_html(self, html, base_url=QUrl()):
self._widget.setHtml(html, base_url)

View File

@ -245,7 +245,7 @@ class TabbedBrowser(QWidget):
tab.new_tab_requested.connect(self.tabopen)
if not self.is_private:
web_history = objreg.get('web-history')
tab.add_history_item.connect(web_history.add_from_tab)
tab.history_item_triggered.connect(web_history.add_from_tab)
def current_url(self):
"""Get the URL of the current tab.