From 573c25073dff4ec2f94ecf12f2378ac7709a518c Mon Sep 17 00:00:00 2001 From: Tomasz Kramkowski Date: Wed, 8 Jun 2016 19:06:00 +0100 Subject: [PATCH 1/2] Fix toggle config using capitalised boolean value. --- qutebrowser/config/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/config/config.py b/qutebrowser/config/config.py index b66ef2969..f788bb7ca 100644 --- a/qutebrowser/config/config.py +++ b/qutebrowser/config/config.py @@ -734,7 +734,7 @@ class ConfigManager(QObject): val = self.get(section_, option) layer = 'temp' if temp else 'conf' if isinstance(val, bool): - self.set(layer, section_, option, str(not val)) + self.set(layer, section_, option, str(not val).lower()) else: raise cmdexc.CommandError( "set: Attempted inversion of non-boolean value.") From a98cd9a528a40d01bdbbf28f7d539c58a4f10535 Mon Sep 17 00:00:00 2001 From: Tomasz Kramkowski Date: Wed, 8 Jun 2016 19:37:13 +0100 Subject: [PATCH 2/2] Change relevant tests to work with new toggle behaviour --- tests/end2end/features/set.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/end2end/features/set.feature b/tests/end2end/features/set.feature index edb455abe..aabb07f7e 100644 --- a/tests/end2end/features/set.feature +++ b/tests/end2end/features/set.feature @@ -26,7 +26,7 @@ Feature: Setting settings. Scenario: Toggling an option When I run :set general auto-save-config false And I run :set general auto-save-config! - Then general -> auto-save-config should be True + Then general -> auto-save-config should be true Scenario: Toggling a non-bool option When I run :set colors statusbar.bg! @@ -44,7 +44,7 @@ Feature: Setting settings. Scenario: Using ! and -p When I run :set general auto-save-config false And I run :set -p general auto-save-config! - Then the message "general auto-save-config = True" should be shown + Then the message "general auto-save-config = true" should be shown Scenario: Setting an invalid value When I run :set general auto-save-config blah