From 4f04c776c1757caacf1b5935358ec79f8a3faf75 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Wed, 24 Jan 2018 22:21:22 +0100 Subject: [PATCH] fixup! fixup! incdec_number: add support for port --- qutebrowser/browser/commands.py | 8 ++++++-- qutebrowser/utils/urlutils.py | 3 ++- tests/unit/utils/test_urlutils.py | 1 - 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py index 6eaa3e167..09a72176a 100644 --- a/qutebrowser/browser/commands.py +++ b/qutebrowser/browser/commands.py @@ -638,9 +638,13 @@ class CommandDispatcher: - `next`: Open a _next_ link. - `up`: Go up a level in the current URL. - `increment`: Increment the last number in the URL. - Uses the link:settings.html#url.incdec_segments[url.incdec_segments] config option. + Uses the + link:settings.html#url.incdec_segments[url.incdec_segments] + config option. - `decrement`: Decrement the last number in the URL. - Uses the link:settings.html#url.incdec_segments[url.incdec_segments] config option. + Uses the + link:settings.html#url.incdec_segments[url.incdec_segments] + config option. tab: Open in a new tab. bg: Open in a background tab. diff --git a/qutebrowser/utils/urlutils.py b/qutebrowser/utils/urlutils.py index 88853483e..0cbe6d88e 100644 --- a/qutebrowser/utils/urlutils.py +++ b/qutebrowser/utils/urlutils.py @@ -561,7 +561,8 @@ def incdec_number(url, incdec, count=1, segments=None): # Order as they appear in a URL segment_modifiers = [ ('host', url.host, url.setHost), - ('port', lambda: str(url.port()) if url.port() > 0 else '', lambda x: url.setPort(int(x))), + ('port', lambda: str(url.port()) if url.port() > 0 else '', + lambda x: url.setPort(int(x))), ('path', url.path, url.setPath), ('query', url.query, url.setQuery), ('anchor', url.fragment, url.setFragment), diff --git a/tests/unit/utils/test_urlutils.py b/tests/unit/utils/test_urlutils.py index de83ba7bf..d7f009a37 100644 --- a/tests/unit/utils/test_urlutils.py +++ b/tests/unit/utils/test_urlutils.py @@ -624,7 +624,6 @@ class TestIncDecNumber: def test_incdec_port(self): """Test incdec_number with port.""" - base_url = QUrl('http://localhost:8000') new_url = urlutils.incdec_number( base_url, 'increment', segments={'port'})