From 4d65abfcc632d47595e2ab8707bc7011a465a7f5 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 22 Mar 2017 06:32:09 +0100 Subject: [PATCH] Check if widget is deleted in _on_webkit_icon_changed --- qutebrowser/browser/webkit/webkittab.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qutebrowser/browser/webkit/webkittab.py b/qutebrowser/browser/webkit/webkittab.py index ac9eea466..ef427c3be 100644 --- a/qutebrowser/browser/webkit/webkittab.py +++ b/qutebrowser/browser/webkit/webkittab.py @@ -23,6 +23,7 @@ import sys import functools import xml.etree.ElementTree +import sip from PyQt5.QtCore import (pyqtSlot, Qt, QEvent, QUrl, QPoint, QTimer, QSizeF, QSize) from PyQt5.QtGui import QKeyEvent @@ -707,6 +708,9 @@ class WebKitTab(browsertab.AbstractTab): @pyqtSlot() def _on_webkit_icon_changed(self): """Emit iconChanged with a QIcon like QWebEngineView does.""" + if sip.isdeleted(self._widget): + log.webview.debug("Got _on_webkit_icon_changed for deleted view!") + return self.icon_changed.emit(self._widget.icon()) @pyqtSlot(QWebFrame)