rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hints: change click position to the center of the largest square fitting to the top/left corner of the rectangle

Browse Source
This commit is contained in:
Jakub Klinkovský 2016-02-16 00:19:22 +01:00
parent 0f8b298fad
commit 4c06e34074
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qutebrowser/browser/hints.py
View File

@ -482,11 +482,15 @@ class HintManager(QObject):
else: else:
target_mapping[Target.tab] = usertypes.ClickTarget.tab target_mapping[Target.tab] = usertypes.ClickTarget.tab
# FIXME Instead of clicking the center, we could have nicer heuristics. # Click the center of the largest square fitting into the top/left
# e.g. parse (-webkit-)border-radius correctly and click text fields at # corner of the rectangle, this will help if part of the <a> element
# the bottom right, and everything else on the top left or so. # is hidden behind other elements
# https://github.com/The-Compiler/qutebrowser/issues/70 # https://github.com/The-Compiler/qutebrowser/issues/1005
rect = self._get_first_rectangle(elem) rect = self._get_first_rectangle(elem)
if rect.width() > rect.height():
rect.setWidth(rect.height())
else:
rect.setHeight(rect.width())
pos = rect.center() pos = rect.center()
action = "Hovering" if context.target == Target.hover else "Clicking" action = "Hovering" if context.target == Target.hover else "Clicking"