From 4b4bb3af88431989997b878acadeb4166303905b Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 26 Feb 2015 20:02:31 +0100 Subject: [PATCH] Handle NavigationTypeOther acceptNavigationRequest This fixes hinting in some cases where javascript is used to load content, e.g. on duckduckgo. However it still doesn't seem to help with github files etc. See #488. --- qutebrowser/browser/webpage.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index 82cc7830e..a48395545 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -498,7 +498,11 @@ class BrowserPage(QWebPage): request: QNetworkRequest typ: QWebPage::NavigationType """ - if typ != QWebPage.NavigationTypeLinkClicked: + if typ not in (QWebPage.NavigationTypeLinkClicked, + QWebPage.NavigationTypeOther): + # If the navigation request isn't a result of clicking or hinting + # (form submit, back/forward, reload), we're not interested in + # handling it ourselves. return True url = request.url() urlstr = url.toDisplayString()