From 4ab5d2df28f7f999882034442d3a8f1b1dce0fce Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 26 Dec 2014 14:26:59 +0100 Subject: [PATCH] Make it possible to enter a keymode twice. If we don't allow this, we can get stuck e.g. when doing this: - Press m to get a quickmark prompt. - Click a javascript prompt button. - Exit the javascript prompt. - We have the quickmark prompt open but we're in normal mode. --- qutebrowser/keyinput/modeman.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/qutebrowser/keyinput/modeman.py b/qutebrowser/keyinput/modeman.py index 5f59394ab..559a92531 100644 --- a/qutebrowser/keyinput/modeman.py +++ b/qutebrowser/keyinput/modeman.py @@ -287,9 +287,6 @@ class ModeManager(QObject): mode, '' if reason is None else ' (reason: {})'.format(reason))) if mode not in self._handlers: raise ValueError("No handler for mode {}".format(mode)) - if self.mode_stack and self.mode_stack[-1] == mode: - log.modes.debug("Already at end of stack, doing nothing") - return self.mode_stack.append(mode) log.modes.debug("New mode stack: {}".format(self.mode_stack)) self.entered.emit(mode, self._win_id)