rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update urlmatch tests for Chromium changes

Browse Source 
See:
0ab1294c92%5E%21/
https://bugs.chromium.org/p/chromium/issues/detail?id=812543
This commit is contained in:
Florian Bruhin 2018-02-23 06:31:49 +01:00
parent eb4c806ddb
commit 49ead32f13
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit/utils/test_urlmatch.py
View File

@ -53,6 +53,7 @@ from qutebrowser.utils import urlmatch
("http://", "Pattern without host"), ("http://", "Pattern without host"),
("http:///", "Pattern without host"), ("http:///", "Pattern without host"),
("http:// /", "Pattern without host"), ("http:// /", "Pattern without host"),
("http://:1234/", "Pattern without host"),
# Chromium: PARSE_ERROR_EMPTY_PATH # Chromium: PARSE_ERROR_EMPTY_PATH
# We deviate from Chromium and allow this for ease of use # We deviate from Chromium and allow this for ease of use
@ -94,8 +95,8 @@ def test_invalid_patterns(pattern, error):
("http://foo:1234/bar", 1234), ("http://foo:1234/bar", 1234),
("http://*.foo:1234/", 1234), ("http://*.foo:1234/", 1234),
("http://*.foo:1234/bar", 1234), ("http://*.foo:1234/bar", 1234),
# https://bugs.chromium.org/p/chromium/issues/detail?id=812543 ("http://*:1234/", 1234),
# ("http://:1234/", 1234), ("http://*:*/", None),
("http://foo:*/", None), ("http://foo:*/", None),
("file://foo:1234/bar", None), ("file://foo:1234/bar", None),
@ -253,7 +254,7 @@ class TestMatchChromeUrls:
class TestMatchAnything: class TestMatchAnything:
@pytest.fixture(params=['*://*/*', '<all_urls>']) @pytest.fixture(params=['*://*/*', '*://*:*/*', '<all_urls>'])
def up(self, request): def up(self, request):
return urlmatch.UrlPattern(request.param) return urlmatch.UrlPattern(request.param)