rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

userscripts: Make fifo private in _QtFIFOReader.

Browse Source
This commit is contained in:
Florian Bruhin 2015-12-12 00:33:50 +01:00
parent 3a2d031479
commit 494d48aac1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/commands/userscripts.py
View File

@ -46,7 +46,7 @@ class _QtFIFOReader(QObject):
# can add O_NONBLOCK. # can add O_NONBLOCK.
# pylint: disable=no-member,useless-suppression # pylint: disable=no-member,useless-suppression
fd = os.open(filepath, os.O_RDWR | os.O_NONBLOCK) fd = os.open(filepath, os.O_RDWR | os.O_NONBLOCK)
self.fifo = os.fdopen(fd, 'r') self._fifo = os.fdopen(fd, 'r')
self._notifier = QSocketNotifier(fd, QSocketNotifier.Read, self) self._notifier = QSocketNotifier(fd, QSocketNotifier.Read, self)
self._notifier.activated.connect(self.read_line) self._notifier.activated.connect(self.read_line)
@ -55,14 +55,14 @@ class _QtFIFOReader(QObject):
"""(Try to) read a line from the FIFO.""" """(Try to) read a line from the FIFO."""
log.procs.debug("QSocketNotifier triggered!") log.procs.debug("QSocketNotifier triggered!")
self._notifier.setEnabled(False) self._notifier.setEnabled(False)
for line in self.fifo: for line in self._fifo:
self.got_line.emit(line.rstrip('\r\n')) self.got_line.emit(line.rstrip('\r\n'))
self._notifier.setEnabled(True) self._notifier.setEnabled(True)
def cleanup(self): def cleanup(self):
"""Clean up so the FIFO can be closed.""" """Clean up so the FIFO can be closed."""
self._notifier.setEnabled(False) self._notifier.setEnabled(False)
self.fifo.close() self._fifo.close()
class _BaseUserscriptRunner(QObject): class _BaseUserscriptRunner(QObject):