Regression test for repeated completion.
Add a completionwidget unit test for #1812: help completion repeatedly completes. Addresses #1899.
This commit is contained in:
parent
e12eb28635
commit
48fe309a48
@ -145,7 +145,8 @@ def test_maybe_resize_completion(completionview, config_stub, qtbot):
|
|||||||
('next-category', [[]], 1, None),
|
('next-category', [[]], 1, None),
|
||||||
('prev-category', [[]], 1, None),
|
('prev-category', [[]], 1, None),
|
||||||
])
|
])
|
||||||
def test_completion_item_focus(which, tree, count, expected, completionview):
|
def test_completion_item_focus(which, tree, count, expected, completionview,
|
||||||
|
qtbot):
|
||||||
"""Test that on_next_prev_item moves the selection properly.
|
"""Test that on_next_prev_item moves the selection properly.
|
||||||
|
|
||||||
Args:
|
Args:
|
||||||
@ -163,12 +164,34 @@ def test_completion_item_focus(which, tree, count, expected, completionview):
|
|||||||
filtermodel = sortfilter.CompletionFilterModel(model,
|
filtermodel = sortfilter.CompletionFilterModel(model,
|
||||||
parent=completionview)
|
parent=completionview)
|
||||||
completionview.set_model(filtermodel)
|
completionview.set_model(filtermodel)
|
||||||
for _ in range(count):
|
if expected is None:
|
||||||
completionview.completion_item_focus(which)
|
for _ in range(count):
|
||||||
|
completionview.completion_item_focus(which)
|
||||||
|
else:
|
||||||
|
with qtbot.waitSignal(completionview.selection_changed):
|
||||||
|
for _ in range(count):
|
||||||
|
completionview.completion_item_focus(which)
|
||||||
idx = completionview.selectionModel().currentIndex()
|
idx = completionview.selectionModel().currentIndex()
|
||||||
assert filtermodel.data(idx) == expected
|
assert filtermodel.data(idx) == expected
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize('which', ['next', 'prev', 'next-category',
|
||||||
|
'prev-category'])
|
||||||
|
def test_completion_item_focus_no_model(which, completionview, qtbot):
|
||||||
|
"""Test that selectionChanged is not fired when the model is None.
|
||||||
|
|
||||||
|
Validates #1812: help completion repeatedly completes
|
||||||
|
"""
|
||||||
|
with qtbot.assertNotEmitted(completionview.selection_changed):
|
||||||
|
completionview.completion_item_focus(which)
|
||||||
|
model = base.BaseCompletionModel()
|
||||||
|
filtermodel = sortfilter.CompletionFilterModel(model,
|
||||||
|
parent=completionview)
|
||||||
|
completionview.set_model(filtermodel)
|
||||||
|
completionview.set_model(None)
|
||||||
|
with qtbot.assertNotEmitted(completionview.selection_changed):
|
||||||
|
completionview.completion_item_focus(which)
|
||||||
|
|
||||||
@pytest.mark.parametrize('show', ['always', 'auto', 'never'])
|
@pytest.mark.parametrize('show', ['always', 'auto', 'never'])
|
||||||
@pytest.mark.parametrize('rows', [[], ['Aa'], ['Aa', 'Bb']])
|
@pytest.mark.parametrize('rows', [[], ['Aa'], ['Aa', 'Bb']])
|
||||||
@pytest.mark.parametrize('quick_complete', [True, False])
|
@pytest.mark.parametrize('quick_complete', [True, False])
|
||||||
|
Loading…
Reference in New Issue
Block a user