From 47218e540269b7aedec9a61998f2eeec44939c15 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sat, 1 Sep 2018 12:10:21 +0200 Subject: [PATCH] sql.Query: Roll back transactions on errors --- qutebrowser/misc/sql.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qutebrowser/misc/sql.py b/qutebrowser/misc/sql.py index eb31834e5..207fc2a40 100644 --- a/qutebrowser/misc/sql.py +++ b/qutebrowser/misc/sql.py @@ -205,7 +205,12 @@ class Query: self._check_ok('transaction', ok) ok = self.query.execBatch() - self._check_ok('execBatch', ok) + try: + self._check_ok('execBatch', ok) + except SqliteError: + # Not checking the return value here, as we're failing anyways... + db.rollback() + raise ok = db.commit() self._check_ok('commit', ok)