rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

TabWidget: a possible fix for #1693 - grey area under custom tabbar

Browse Source 
Attempt to fix the issue #1693 by:
- setting the TabBarStyle to TabWidget in addition to TabBar
- chain up SE_TabWidgetTabBar requests in TabBarStyle.subElementRect
  to the super() rather than self._style, in order to avoid getting
  adwaita-specific rect sizes instead of default ones that are also
  used in rendering.
This commit is contained in:
Rok Mandeljc 2016-08-29 14:05:19 +02:00
parent 0b7a71e18e
commit 469590d4e8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qutebrowser/mainwindow/tabwidget.py
View File

@ -50,6 +50,7 @@ class TabWidget(QTabWidget):
def __init__(self, win_id, parent=None): def __init__(self, win_id, parent=None):
super().__init__(parent) super().__init__(parent)
bar = TabBar(win_id) bar = TabBar(win_id)
self.setStyle(TabBarStyle(self.style()))
self.setTabBar(bar) self.setTabBar(bar)
bar.tabCloseRequested.connect(self.tabCloseRequested) bar.tabCloseRequested.connect(self.tabCloseRequested)
bar.tabMoved.connect(functools.partial( bar.tabMoved.connect(functools.partial(
@ -656,6 +657,12 @@ class TabBarStyle(QCommonStyle):
if sr == QStyle.SE_TabBarTabText: if sr == QStyle.SE_TabBarTabText:
layouts = self._tab_layout(opt) layouts = self._tab_layout(opt)
return layouts.text return layouts.text
elif sr == QStyle.SE_TabWidgetTabBar:
# Need to use super() because we also use super() to render
# element in drawControl(); otherwise, we may get bit by
# style differences...
rct = super().subElementRect(sr, opt, widget)
return rct
else: else:
return self._style.subElementRect(sr, opt, widget) return self._style.subElementRect(sr, opt, widget)