From 469175396500235c620030938befaa8b55f6af1d Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 19 Feb 2018 05:19:25 +0100 Subject: [PATCH] Avoid running change handlers on config.clear --- qutebrowser/config/config.py | 5 +++-- qutebrowser/config/configutils.py | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/qutebrowser/config/config.py b/qutebrowser/config/config.py index baadf1cfa..b3ebc97c3 100644 --- a/qutebrowser/config/config.py +++ b/qutebrowser/config/config.py @@ -415,8 +415,9 @@ class Config(QObject): file. """ for name, values in self._values.items(): - values.clear() - self.changed.emit(name) + cleared = values.clear() + if cleared: + self.changed.emit(name) if save_yaml: self._yaml.clear() diff --git a/qutebrowser/config/configutils.py b/qutebrowser/config/configutils.py index c915b7674..cae1de7b7 100644 --- a/qutebrowser/config/configutils.py +++ b/qutebrowser/config/configutils.py @@ -92,7 +92,9 @@ class Values: def clear(self): """Clear all customization for this value.""" + had_values = bool(self._values) self._values = [] + return had_values def _get_fallback(self): """Get the fallback global/default value."""