rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tests: Hopefully fix keyinput.feature flakiness.

Browse Source 
While the original "no focused webview" bug (with the first test after spawning
qutebrowser) from #1183 was fixed, we still had a case where the next test
after ":fake-key sending key to the website with other window focused" failed,
presumably because the inspector was still focused, e.g. here:

http://qutebrowser.org:8010/builders/osx/builds/1175/steps/tests/logs/stdio

This hopefully fixes this by properly waiting until the inspector is gone.
This commit is contained in:
Florian Bruhin 2015-12-18 07:13:16 +01:00
parent eed4a992ab
commit 45d6dc6aa3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration/features/keyinput.feature
View File

@ -121,7 +121,7 @@ Feature: Keyboard input
And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log And I wait for "Focus object changed: <PyQt5.QtWebKitWidgets.QWebView object at *>" in the log
And I run :fake-key x And I run :fake-key x
And I run :inspector And I run :inspector
And I wait for "Focus object changed: *" in the log And I wait for "Focus object changed: <qutebrowser.browser.webview.WebView *>" in the log
Then the error "No focused webview!" should be shown Then the error "No focused webview!" should be shown
Scenario: :fake-key sending special key to the website Scenario: :fake-key sending special key to the website