diff --git a/qutebrowser/utils/javascript.py b/qutebrowser/utils/javascript.py index 9eef12e72..4fc7e546c 100644 --- a/qutebrowser/utils/javascript.py +++ b/qutebrowser/utils/javascript.py @@ -64,8 +64,8 @@ def _convert_js_arg(arg): def assemble(module, function, *args): """Assemble a javascript file and a function call.""" js_args = ', '.join(_convert_js_arg(arg) for arg in args) - if module in ['window', 'document']: - parts = [module, function] + if module == 'window': + parts = ['window', function] else: parts = ['window', '_qutebrowser', module, function] code = '"use strict";\n{}({});'.format('.'.join(parts), js_args) diff --git a/tests/unit/utils/test_javascript.py b/tests/unit/utils/test_javascript.py index f379322e8..298a75312 100644 --- a/tests/unit/utils/test_javascript.py +++ b/tests/unit/utils/test_javascript.py @@ -142,7 +142,6 @@ def test_convert_js_arg(arg, expected): @pytest.mark.parametrize('base, expected_base', [ ('window', 'window'), - ('document', 'document'), ('foo', 'window._qutebrowser.foo'), ]) def test_assemble(base, expected_base):