rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

flake8 requirements: Get rid of ebb-lint

Browse Source 
We've had many checks disabled - these are the ones we actually lose:

    L104
    Docstrings must use Napoleon, not reStructuredText fields.

    L205
    __init__.py is not allowed to contain function or class definitions.

    L206
    Implicit relative imports are not allowed.

    L208
    Pokémon exception handling is always a mistake. If the intent is
    really to catch and ignore exceptions, explicitly name which
    exception types to silence.

    L209
    return, del, raise, assert, print (in python 2, without
    print_function) yield, and yield from are statements, not functions,
    and as such, do not require parentheses.

    L210
    Instead of intentionally relying on the side effects of map, filter,
    or a comprehension, write an explicit for loop.

    L211
    Using map or filter with a lambda as the first argument is always
    better written as list comprehension or generator expression. An
    expression is more readable and extensible, and less importantly,
    doesn't incur as much function call overhead.

    L212
    Using @staticmethod is always wrong.

    L301
    Files must end with a trailing newline.

    L303
    noqa is ignored, and as such, # noqa comments should be deleted to
    reduce pointless noise.

However, most of those are also checked by pylint (and the rest I don't
really care about), and ebb-lint increases flake8's runtime a lot
(45s -> almost 2min).
This commit is contained in:
Florian Bruhin 2016-07-13 07:21:13 +02:00
parent 46bdfa2932
commit 4328169274
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.flake8
View File

@ -8,17 +8,6 @@ exclude = .venv,.hypothesis,.git,__pycache__,resources.py
# E266: too many leading '#' for block comment
# F401: Unused import
# N802: function name should be lowercase
# L101: The __init__ method of classes must not have a docstring
# L102: A docstring was incorrectly formatted.
# L103: A test docstring must not start with any form of the words "test", ...
# L201: Container literals must have a trailing comma
# L202: print is not allowed except for debugging.
# L203: pdb and compatible modules are not allowed except for debugging.
# L204: Implicit string literal concatenation is only allowed if every string
# being concatenated is parenthesize
# L207: pass is only necessary in non-optional suites containing no other
# statements.
# L302: The line was too long.
# P101: format string does contain unindexed parameters
# P102: docstring does contain unindexed parameters
# P103: other string does contain unindexed parameters
@ -41,7 +30,6 @@ ignore =
E128,E226,E265,E501,E402,E266,
F401,
N802,
L101,L102,L103,L201,L202,L203,L204,L207,L302,
P101,P102,P103,
D102,D103,D104,D105,D209,D211,D402,D403,
H101,H201,H238,H301,H306

4
misc/requirements/requirements-flake8.txt
View File

@ -1,6 +1,5 @@
# This file is automatically generated by scripts/dev/recompile_requirements.py
ebb-lint==0.4.4
flake8==2.6.2
flake8-copyright==0.2.0
flake8-debugger==1.4.0
@ -14,7 +13,6 @@ flake8-string-format==0.2.2
flake8-tidy-imports==1.0.2
flake8-tuple==0.2.11
hacking==0.11.0
intervaltree==2.1.0
mccabe==0.5.0
packaging==16.7
pbr==1.10.0
@ -26,5 +24,3 @@ pydocstyle==1.0.0
pyflakes==1.2.3
pyparsing==2.1.5
six==1.10.0
sortedcontainers==1.5.3
venusian==1.0

1
misc/requirements/requirements-flake8.txt-raw
View File

@ -1,4 +1,3 @@
ebb-lint
flake8
flake8-copyright
flake8-debugger