From 40e1337e037197c3319bc0a8386445215c9b2b9c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 17 Feb 2017 06:56:12 +0100 Subject: [PATCH] Adjust WebEngineEleement _js_dict in remove_blank_target Otherwise, when checking later if the element has target=_blank set, we still think it is. This is not perfect as remove_blank_target also removes it from sub-elements, but it's a good start. --- qutebrowser/browser/webengine/webengineelem.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/browser/webengine/webengineelem.py b/qutebrowser/browser/webengine/webengineelem.py index 40d467f43..36f4e0e64 100644 --- a/qutebrowser/browser/webengine/webengineelem.py +++ b/qutebrowser/browser/webengine/webengineelem.py @@ -147,6 +147,8 @@ class WebEngineElement(webelem.AbstractWebElement): return QRect() def remove_blank_target(self): + if self._js_dict['attributes'].get('target') == '_blank': + self._js_dict['attributes']['target'] = '_top' js_code = javascript.assemble('webelem', 'remove_blank_target', self._id) self._tab.run_js_async(js_code)