From 40af99bacc922e9c34519db012cd9602e7b79c83 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 3 Mar 2015 23:28:45 +0100 Subject: [PATCH] Clear open target in acceptNavigationRequest. This is a regression introduced in a76868c0f4a189e2a2b53a9acbaa6ccc272e55a6. Fixes #530. --- qutebrowser/browser/webpage.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index 2203ae18c..cd77a1090 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -535,6 +535,7 @@ class BrowserPage(QWebPage): message.error(self._win_id, "Invalid link {} clicked!".format( urlstr)) log.webview.debug(url.errorString()) + self.open_target = usertypes.ClickTarget.normal return False tabbed_browser = objreg.get('tabbed-browser', scope='window', window=self._win_id) @@ -546,6 +547,7 @@ class BrowserPage(QWebPage): target = self._hint_target else: target = self.open_target + self.open_target = usertypes.ClickTarget.normal if target == usertypes.ClickTarget.tab: tabbed_browser.tabopen(url, False) return False