From 3fe64085f8b91b6d8ee6b17665e2e6ae7e8a1bdb Mon Sep 17 00:00:00 2001
From: Florian Bruhin <me@the-compiler.org>
Date: Mon, 8 Oct 2018 19:43:25 +0200
Subject: [PATCH] Add tabindex to default 'all' selector

See #178
---
 doc/help/settings.asciidoc                   | 1 +
 qutebrowser/config/configdata.yml            | 1 +
 tests/unit/browser/webkit/test_webkitelem.py | 2 ++
 3 files changed, 4 insertions(+)

diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc
index 1f5812811..db0802349 100644
--- a/doc/help/settings.asciidoc
+++ b/doc/help/settings.asciidoc
@@ -2609,6 +2609,7 @@ Default:
 * +pass:[[ngClick]]+
 * +pass:[[data-ng-click]]+
 * +pass:[[x-ng-click]]+
+* +pass:[[tabindex]]+
 - +pass:[images]+:
 
 * +pass:[img]+
diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml
index 550d73c66..d30041712 100644
--- a/qutebrowser/config/configdata.yml
+++ b/qutebrowser/config/configdata.yml
@@ -1186,6 +1186,7 @@ hints.selectors:
       - '[ngClick]'
       - '[data-ng-click]'
       - '[x-ng-click]'
+      - '[tabindex]'
     links:
       - 'a[href]'
       - 'area[href]'
diff --git a/tests/unit/browser/webkit/test_webkitelem.py b/tests/unit/browser/webkit/test_webkitelem.py
index 0bfb61066..09be16848 100644
--- a/tests/unit/browser/webkit/test_webkitelem.py
+++ b/tests/unit/browser/webkit/test_webkitelem.py
@@ -183,6 +183,8 @@ class SelectionAndFilterTests:
         ('<p role="option" foo="bar"/>', ['all']),
         ('<p role="button" foo="bar"/>', ['all']),
         ('<p role="button" href="bar"/>', ['all', 'url']),
+
+        ('<span tabindex=0 />', ['all']),
     ]
 
     GROUPS = ['all', 'links', 'images', 'url', 'inputs']